Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code: Reduce the number of times one has to use NVDA+Space to switch modes. #10888

Closed
MarcoZehe opened this issue Mar 20, 2020 · 3 comments · Fixed by #10903 or #10921
Closed

VS Code: Reduce the number of times one has to use NVDA+Space to switch modes. #10888

MarcoZehe opened this issue Mar 20, 2020 · 3 comments · Fixed by #10903 or #10921
Labels
app/vs-code blocked/needs-external-fix enhancement
Milestone
2020.1

Comments

@MarcoZehe
Copy link
Contributor

I just filed this issue against VS Code where I suggest to use targeted role="document" in those places that produce HTML output for consumption, to make NVDA switch in and out of browse mode in a smart, automated, manner, reducing the number of times one has to use NVDA+Space to toggle modes. Examples I found while using the 1.44 VS Code Insider builds were:

  • The Welcome page
  • The details page for an extension
  • The ReadMe file that may be displayed after an extension has been installed.

@LeonarddeR suggested that, once this lands in stable, a modification might be needed for the VS Code app module. So filing this issue here.
@LeonarddeR
Copy link
Collaborator

Added the needs external fix label. As soon as microsoft/vscode#93087 is addressed, we can reconsider the behavior of our appModules.

@MarcoZehe
Copy link
Contributor Author

VS Code insider builds now have the fix for role="document" in some places where they make sense, and more are being added as they're discovered. I think we can reevaluate now whether the VS app module still makes sense. The Insider one can certainly be removed, the other one once VS Code 1.44 gets released.

@MarcoZehe MarcoZehe mentioned this issue Mar 26, 2020
Merged
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Mar 31, 2020
@LeonarddeR
Copy link
Collaborator

This should be fixed for Code Insiders now. As soon as the april update of Code is there, we can revert

@LeonarddeR LeonarddeR mentioned this issue Mar 31, 2020
Merged
@feerrenrut feerrenrut removed this from the 2020.1 milestone Apr 30, 2020
feerrenrut pushed a commit that referenced this issue Apr 30, 2020
@LeonarddeR
Revert "appModule for VS Code (PR #9828)" (PR #10921)
e095f81 
This reverts commit 480950f.

Removes the no-longer needed code.py appmodule.
Follow up of #10903 (removed the no-longer needed code - insiders.py appmodule)
Reverts #9828 (creating the code.py appmodule)

Changes to VS Code fixing #10888 have now made it stable. Therefore, remove the appModule which worked around these issues.
Note: Users can continue to force disable browse mode by default using a profile automatically triggered when entering vsCode that unchecks "Enable browse mode on page load" on the browse mode settings panel.
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/vs-code blocked/needs-external-fix enhancement
Projects
None yet
Milestone
2020.1
4 participants
@MarcoZehe @LeonarddeR @feerrenrut @nvaccessAuto