Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate downloading of dependent source packages #88

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 26, 2024

Description

  • This attempts to automate 95% of the work involved in downloading source code for third-party dependencies.
  • Contained is the common code intended to be shared between MRC & Morpheus
    • Reads dependencies from a Conda environment yaml file, along with the resolved versions from conda list --json (ex: replace a version spec like >=1.9.2,<1.10.0a0 with the actual version used).
  • Attempts to locate the package on github and gitlab, and attempts to find a release tag of the same name.
  • Downloads/extracts the tar.gz files

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner November 26, 2024 19:57
@dagardner-nv dagardner-nv self-assigned this Nov 26, 2024
@dagardner-nv dagardner-nv marked this pull request as draft November 26, 2024 19:57
@dagardner-nv dagardner-nv added non-breaking Non-breaking change 2 - In Progress PR/Issue is currently a work in progress improvement Improvement to existing functionality labels Nov 26, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review November 26, 2024 23:05
@dagardner-nv dagardner-nv removed the 2 - In Progress PR/Issue is currently a work in progress label Nov 26, 2024
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 59ed808 into nv-morpheus:branch-25.02 Jan 15, 2025
2 checks passed
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this pull request Jan 15, 2025
* This attempts to automate 95% of the work involved in downloading source code for third-party dependencies and alerting the user to the 5% that needs to be done by hand.
* Adds a runtime dependencies Conda target

Requires nv-morpheus/utilities#88 to be merged first.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #519
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Jan 15, 2025
* This attempts to automate 95% of the work involved in downloading source code for third-party dependencies [nv-morpheus/morpheus_third_party_oss](https://github.com/nv-morpheus/morpheus_third_party_oss) and alerting the user to the 5% that needs to be done by hand.

Requires nv-morpheus/utilities#88 to be merged first.


## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #2062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants