Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch from pybind11 #43

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Remove patch from pybind11 #43

merged 5 commits into from
Jun 21, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 12, 2023 •
edited
Loading

Description

  • Removes pybind11 patch
  • All MRC & Morpheus tests are passing with this change

Part of nv-morpheus/Morpheus#961

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change 2 - In Progress PR/Issue is currently a work in progress improvement Improvement to existing functionality labels Jun 12, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner June 12, 2023 17:31
@dagardner-nv dagardner-nv added 3 - Ready for Review PR/Issue is complete and ready for review by team and removed 2 - In Progress PR/Issue is currently a work in progress labels Jun 12, 2023
mdemoret-nv
mdemoret-nv requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested using pybind11 from Conda?

@dagardner-nv
Copy link
Contributor Author

Have you tested using pybind11 from Conda?

Yes I did, I tested two setups:

  1. As-is without the patch installed via CPM
  2. Using conda installed pybind11 which was the newish v2.10.4

Both worked, but I wanted to do it as a two-step

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a5b9689 into nv-morpheus:branch-23.07 Jun 21, 2023
@dagardner-nv dagardner-nv deleted the david-pybind11-961 branch June 21, 2023 22:06
@dagardner-nv dagardner-nv mentioned this pull request Jun 21, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this pull request Jun 26, 2023
@dagardner-nv
Remove patch from pybind11 (#335)
7efa871 
* Adopt updated utilities repo to pickup changes from nv-morpheus/utilities#43
* Removes pybind11 patch

Part of nv-morpheus/Morpheus#961

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #335
@dagardner-nv dagardner-nv mentioned this pull request Jun 27, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Jun 29, 2023
@dagardner-nv
Remove patch from pybind11 (#1001)
4e3b669 
* Adopt updated utilities repo to pickup changes from nv-morpheus/utilities#43
* Removes pybind11 patch

fixes #961

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
3 - Ready for Review PR/Issue is complete and ready for review by team improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv