Bugfix: Remove MRC_USE_CONDA option since it must always be On #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Killian <[email protected]>
willkill07
added
non-breaking
dagardner-nv
reviewed
Feb 5, 2025
|
@dagardner-nv this is MRC, not Morpheus |
dagardner-nv
approved these changes
Feb 5, 2025
3 tasks
rapids-bot bot
pushed a commit
to nv-morpheus/utilities
that referenced
this pull request
Feb 5, 2025
#99) Yet another PR for the cleanup of `_USE_CONDA` options This is another step in nv-morpheus/Morpheus#2154 which is required by Morpheus after merging nv-morpheus/MRC#539 Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #99
|
/merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.06 #539 +/- ##
================================================
+ Coverage 73.98% 74.03% +0.05%
================================================
Files 407 407
Lines 15104 15103 -1
Branches 1198 1198
================================================
+ Hits 11174 11181 +7
+ Misses 3930 3922 -8
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MRC_USE_CONDAsince it must always be on.mrc.code-workspaceThis necessary as part of nv-morpheus/Morpheus#2154
Checklist