Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build interface includes #514

Merged

Conversation

cwharris
Copy link
Contributor

Description

build interface includes was accidentally using

.../build/conda/cuda-12.5/release/autogenerated/include

instead of

.../build/conda/cuda-12.5/release/cpp/mrc/autogenerated/include

this PR fixes that, such when depending on mrc from down-stream libraries, the following error does not occur:

CMake Error in python/morpheus_llm/morpheus_llm/_lib/CMakeLists.txt:
  Imported target "mrc::pymrc" includes non-existent path

    "/home/coder/mrc/build/conda/cuda-12.5/release/autogenerated/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels Oct 24, 2024
@cwharris cwharris requested a review from a team as a code owner October 24, 2024 20:39
@cwharris cwharris changed the base branch from branch-25.02 to branch-24.10 October 24, 2024 20:42
@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 06d4ea1 into nv-morpheus:branch-24.10 Oct 24, 2024
16 of 17 checks passed
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (7abfdf7) to head (9e1535d).
Report is 1 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #514      +/-   ##
================================================
- Coverage         74.17%   74.15%   -0.03%     
================================================
  Files               407      407              
  Lines             15049    15049              
  Branches           1191     1191              
================================================
- Hits              11163    11159       -4     
- Misses             3886     3890       +4     
Flag Coverage Δ
cpp 70.69% <ø> (-0.03%) ⬇️
py 44.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abfdf7...9e1535d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants