Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #506

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Oct 21, 2024

Description

This PR is replacing the VAULT_HOST variable with AWS_ROLE_ARN. This is required to use the new token service to get AWS credentials

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jjacobelli jjacobelli added improvement Improvement to existing functionality non-breaking Non-breaking change labels Oct 21, 2024
@jjacobelli jjacobelli self-assigned this Oct 21, 2024
@jjacobelli jjacobelli marked this pull request as ready for review October 22, 2024 14:33
@jjacobelli jjacobelli requested a review from a team as a code owner October 22, 2024 14:33
@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 61862b5 into nv-morpheus:branch-24.10 Oct 22, 2024
16 of 17 checks passed
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (4f23470) to head (adad84e).
Report is 2 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #506      +/-   ##
================================================
+ Coverage         73.97%   73.99%   +0.02%     
================================================
  Files               403      403              
  Lines             14472    14472              
  Branches           1138     1139       +1     
================================================
+ Hits              10705    10708       +3     
+ Misses             3767     3764       -3     
Flag Coverage Δ
cpp 70.54% <ø> (+0.02%) ⬆️
py 42.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f23470...adad84e. Read the comment docs.

@jjacobelli jjacobelli deleted the devcontainers-vault branch October 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants