-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass a mrc.Subscription
object to sources rather than a mrc.Subscriber
#499
Pass a mrc.Subscription
object to sources rather than a mrc.Subscriber
#499
Conversation
mrc.Subscription
object to sources rather than a mrc.Subscriber
/merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #499 +/- ##
================================================
- Coverage 74.12% 74.10% -0.03%
================================================
Files 403 403
Lines 14424 14439 +15
Branches 1135 1136 +1
================================================
+ Hits 10692 10700 +8
- Misses 3732 3739 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
make_source_subscriber
method in favor of inspecting the Python function signature.make_source_subscriber
method was never part of a release I think this can still be considered a non-breaking change.Checklist