Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a mrc.Subscription object to sources rather than a mrc.Subscriber #499

Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Remove the make_source_subscriber method in favor of inspecting the Python function signature.
  • Since the make_source_subscriber method was never part of a release I think this can still be considered a non-breaking change.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Sep 16, 2024
@dagardner-nv dagardner-nv self-assigned this Sep 16, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner September 16, 2024 16:40
@dagardner-nv dagardner-nv changed the title Pass a subscription object to sources rather than a subscriber Pass a mrc.Subscription object to sources rather than a mrc.Subscriber Sep 16, 2024
@dagardner-nv dagardner-nv marked this pull request as draft September 16, 2024 18:06
@dagardner-nv dagardner-nv marked this pull request as ready for review September 16, 2024 18:45
@dagardner-nv dagardner-nv marked this pull request as draft September 16, 2024 18:46
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 48d17a1 into nv-morpheus:branch-24.10 Sep 17, 2024
17 checks passed
@dagardner-nv dagardner-nv deleted the david-subscription-overload branch September 17, 2024 15:10
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (ccbcd76) to head (e9ea972).
Report is 1 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #499      +/-   ##
================================================
- Coverage         74.12%   74.10%   -0.03%     
================================================
  Files               403      403              
  Lines             14424    14439      +15     
  Branches           1135     1136       +1     
================================================
+ Hits              10692    10700       +8     
- Misses             3732     3739       +7     
Flag Coverage Δ
cpp 70.60% <8.69%> (-0.12%) ⬇️
py 42.65% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/mrc/_pymrc/include/pymrc/segment.hpp 62.50% <ø> (ø)
python/mrc/_pymrc/src/segment.cpp 81.67% <100.00%> (+1.44%) ⬆️
python/mrc/_pymrc/src/subscriber.cpp 27.27% <100.00%> (-1.03%) ⬇️
python/mrc/core/segment.cpp 95.74% <ø> (-0.09%) ⬇️
python/mrc/core/subscriber.cpp 88.46% <100.00%> (+0.46%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbcd76...e9ea972. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants