Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper initialization of CMAKE_INSTALL_PREFIX if needed #485

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 16, 2024

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change skip-ci Optionally Skip CI for this PR labels Jul 16, 2024
@dagardner-nv dagardner-nv self-assigned this Jul 16, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 16, 2024 00:03
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (8377f6a) to head (91963c4).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #485      +/-   ##
================================================
- Coverage         74.09%   74.08%   -0.01%     
================================================
  Files               403      403              
  Lines             14401    14402       +1     
  Branches           1132     1132              
================================================
  Hits              10670    10670              
- Misses             3731     3732       +1     
Flag Coverage Δ
cpp 70.85% <ø> (+<0.01%) ⬆️
py 41.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8377f6a...91963c4. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bceb7ef into nv-morpheus:branch-24.10 Jul 24, 2024
18 checks passed
@dagardner-nv dagardner-nv deleted the david-install-prefix branch July 24, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants