Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve rapids-dependency-file-generator warning #482

Merged
merged 2 commits into from
Jun 17, 2024
Merged

resolve rapids-dependency-file-generator warning #482

merged 2 commits into from
Jun 17, 2024

Conversation

jameslamb
Copy link
Contributor

@jameslamb jameslamb commented Jun 12, 2024

Description

Contributes to rapidsai/dependency-file-generator#89.

--file_key has been deprecated in rapids-dependency-file-generator for a few months, and I'm looking to fully remove it.

This PR proposes:

  • switching this project's uses from --file_key to --file-key
  • updating the version of rapids-dependency-file-generator used in pre-commit to its latest release
  • switching from mamba env create --force to mamba env create --yes

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb requested a review from a team as a code owner June 12, 2024 20:15
@jameslamb
Copy link
Contributor Author

CI on the first run failed with this error:

usage: mamba [-h] command ...
mamba: error: unrecognized arguments: --force
[rapids-conda-retry] conda returned exit code: 2
[rapids-conda-retry] Exiting, no retryable mamba errors detected: 'ChecksumMismatchError:', 'ChunkedEncodingError:', 'CondaHTTPError:', 'CondaMultiError:', 'Connection broken:', 'ConnectionError:', 'EOFError:', 'JSONDecodeError:', 'Multi-download failed', 'Timeout was reached', segfault exit code 139
[rapids-conda-retry] 

(build link)

I just pushed a commit switching that to --yes. This failure comes from using a newer version of mamba that no longer supports env create --force. More context here:

@cwharris cwharris added improvement Improvement to existing functionality non-breaking Non-breaking change labels Jun 17, 2024
@cwharris
Copy link
Contributor

/merge

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (7b599a3) to head (3d1a6ce).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-24.06     #482   +/-   ##
=============================================
  Coverage         74.08%   74.09%           
=============================================
  Files               403      403           
  Lines             14401    14401           
  Branches           1132     1132           
=============================================
+ Hits              10669    10670    +1     
+ Misses             3732     3731    -1     
Flag Coverage Δ
cpp 70.85% <ø> (ø)
py 41.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b599a3...3d1a6ce. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 439d7df into nv-morpheus:branch-24.06 Jun 17, 2024
17 checks passed
@jameslamb jameslamb deleted the dfg-warning branch June 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants