Dynamically loading libnvidia-ml.so.1 instead of directly linking

[mdemoret-nv]

Currently, we install the driver into one of the CI images to allow for stub generation during compilation. This was needed because device_info.cpp linked directly against CUDA::nvml. This caused a link dependency on a driver library which is problematic when building with CPU-only docker images.

Instead, we dynamically load libnvidia-ml.so.1 (appending the .so.1 to avoid collisions with the stub file libnvidia-ml.so) and the necessary functions at runtime. If the library is not found, using a GPU will be disabled. This allows loading of the library for stub generation without needing a GPU.

[dagardner-nv]

LGTM, I wonder if there is any advantage to keeping container and test_container in the event that we ever do need additional packages for either the build or the test.

Similarly I think we should update the DOCKER_TARGET array in external/utilities/ci/runner/build_and_push.sh script to :

DOCKER_TARGET=${DOCKER_TARGET:-"build" "test"}

Even if for MRC the build and test targets remain aliases for base.

[mdemoret-nv]

LGTM, I wonder if there is any advantage to keeping container and test_container in the event that we ever do need additional packages for either the build or the test.

Similarly I think we should update the DOCKER_TARGET array in external/utilities/ci/runner/build_and_push.sh script to :

DOCKER_TARGET=${DOCKER_TARGET:-"build" "test"}

Even if for MRC the build and test targets remain aliases for base.

Good point. Changed the names of the targets to build and test with the matching changes here: nv-morpheus/utilities#30

[codecov]

Codecov Report

Merging #313 (62e1ca4) into branch-23.07 (c3f67c0) will decrease coverage by 0.04%.
The diff coverage is 56.60%.

Additional details and impacted files

@@               Coverage Diff                @@
##           branch-23.07     #313      +/-   ##
================================================
- Coverage         73.28%   73.24%   -0.04%     
================================================
  Files               390      390              
  Lines             13352    13379      +27     
  Branches           1006     1008       +2     
================================================
+ Hits               9785     9800      +15     
- Misses             3567     3579      +12     

Flag	Coverage Δ
cpp	69.07% <56.60%> (-0.04%)	⬇️
py	42.22% <56.60%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cpp/mrc/src/tests/test_topology.cpp	98.41% <ø> (-0.05%)	⬇️
cpp/mrc/src/internal/system/topology.cpp	83.33% <50.00%> (-0.72%)	⬇️
cpp/mrc/src/internal/system/device_info.cpp	55.55% <56.86%> (+2.61%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f67c0...62e1ca4. Read the comment docs.

[mdemoret-nv]

/merge