Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license headers to only use a single /* comment to exclude it from doxygen #307

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 3, 2023

Prevents the license header from being repeatedly displayed as part of each namespace's documentation.

Discovered this while looking into nv-morpheus/Morpheus#837

@dagardner-nv dagardner-nv added doc Improvements or additions to documentation non-breaking Non-breaking change 3 - Ready for Review labels Apr 3, 2023
@dagardner-nv dagardner-nv requested review from a team as code owners April 3, 2023 22:22
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #307 (1e8cfc0) into branch-23.07 (1509f6c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #307   +/-   ##
=============================================
  Coverage         73.27%   73.27%           
=============================================
  Files               390      390           
  Lines             13353    13353           
  Branches           1006     1007    +1     
=============================================
  Hits               9785     9785           
  Misses             3568     3568           
Flag Coverage Δ
cpp 69.10% <ø> (ø)
py 42.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/mrc/include/mrc/benchmarking/segment_watcher.hpp 55.79% <ø> (ø)
.../mrc/include/mrc/benchmarking/trace_statistics.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/benchmarking/tracer.hpp 76.74% <ø> (ø)
cpp/mrc/include/mrc/channel/buffered_channel.hpp 47.61% <ø> (ø)
cpp/mrc/include/mrc/channel/channel.hpp 81.81% <ø> (ø)
cpp/mrc/include/mrc/channel/egress.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/channel/ingress.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/channel/null_channel.hpp 54.16% <ø> (ø)
cpp/mrc/include/mrc/channel/recent_channel.hpp 47.91% <ø> (ø)
cpp/mrc/include/mrc/codable/api.hpp 100.00% <ø> (ø)
... and 171 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1509f6c...1e8cfc0. Read the comment docs.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 3762692 into nv-morpheus:branch-23.07 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants