Fix nullptr dereference in NvmlState (#319)

Fixes a bug where `NvmlState` was dereferencing a `nullptr` when `libnvidia-ml.so.1` is not available. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Devin Robison (https://github.com/drobison00) URL: #319
nv-morpheus · Apr 14, 2023 · b207fd6 · b207fd6
1 parent 810a7a6
commit b207fd6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/ci/conda/recipes/run_conda_build.sh b/ci/conda/recipes/run_conda_build.sh
@@ -99,7 +99,7 @@ fi
 # Choose default variants
 if hasArg quick; then
    # For quick build, just do most recent version of rapids
-   CONDA_ARGS_ARRAY+=("rapids_version: 23.02}")
+   CONDA_ARGS_ARRAY+=("--variants" "{rapids_version: 23.02}")
 fi
 
 # And default channels

diff --git a/cpp/mrc/src/internal/system/device_info.cpp b/cpp/mrc/src/internal/system/device_info.cpp
@@ -213,7 +213,10 @@ struct NvmlState
     }
     ~NvmlState()
     {
-        MRC_CHECK_NVML(m_nvml_handle->nvmlShutdown());
+        if (m_nvml_handle)
+        {
+            MRC_CHECK_NVML(m_nvml_handle->nvmlShutdown());
+        }
     }
 
     NvmlHandle& get_handle()

diff --git a/python/mrc/_pymrc/CMakeLists.txt b/python/mrc/_pymrc/CMakeLists.txt
@@ -12,7 +12,7 @@
 # the License.
 # =============================================================================
 
-find_package(Python 3.10 REQUIRED COMPONENTS Development Interpreter)
+find_package(Python 3.8 REQUIRED COMPONENTS Development Interpreter)
 find_package(pybind11 REQUIRED)
 find_package(prometheus-cpp REQUIRED)