WAR for TBLIS compiler detection while upstream PR is pending #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
added
the
category:bug-fix
manopapad
added a commit
to manopapad/cunumeric
that referenced
this pull request
May 2, 2023
…nv-legate#890)" This reverts commit 0e0ea0f.
manopapad
added a commit
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the previous symlink-following behavior that #880 changed was necessary on some systems, because on those systems
/usr/bin/ccwas a symlink to/usr/bin/gcc, and TBLIS is using the output from--versionto discover the compiler vendor, and for gcc the actual compiler name reported on the--versionoutput is not the literal string "gcc", but rather the name of the program used to launch the compiler (i.e.argv[0]). I submitted devinamatthews/tblis#56 to work around this issue. Switching to using the PR branch on my personal fork of TBLIS, until that PR gets merged upstream.