Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FormGroup): add eager validation #992

Merged
merged 6 commits into from
Nov 21, 2023
Merged

feat(FormGroup): add eager validation #992

merged 6 commits into from
Nov 21, 2023
+38 −2

Conversation

connerblanton
Copy link
Contributor

🔗 Linked issue

#891

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently form validation doesn't run on the Input and Textarea components until after their initial blur. This change adds an eager-validation prop to the Input and Textarea components. This will allow users to specify if they want validation to run while the end user is typing.

A callout has been added to the Form docs to explain that no validation runs until after blur and that this new prop can be used to override that behavior

Resolves #891

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 21, 2023 8:01pm

@benjamincanac benjamincanac requested a review from romhml November 18, 2023 16:02
romhml
romhml approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @connerblanton 😄!

@connerblanton connerblanton changed the title feat(Input & Textarea): add eager validation feat(FormGroup): add eager validation Nov 21, 2023
@benjamincanac benjamincanac merged commit d39e2de into nuxt:dev Nov 21, 2023
1 check passed
@benjamincanac
Copy link
Member

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form validate doesn't run on input event
3 participants
@connerblanton @benjamincanac @romhml