-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for the module #892
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Thanks for taking the initiative of starting this! π Do you think it would make sense to use https://github.com/danielroe/nuxt-vitest? |
Definitely that could be used when testing the components. The package seems to be targeted more on testing nuxt applications instead of modules. Can look into it. To prevent feature creep for this PR the component testing should probably be in different PR. Should I still update the contribution guidelines in doc for this PR? How about build process? |
Not sure about the contribution guidelines as there is a draft PR that changes it already: #860 For the build process, you can just add a |
@benjamincanac I can't see what is the problem with Vercel. I added the test steps to the ci files. |
Should be good now! π |
The CI seems to be ok and build passes. Is this PR ok to complete or should I add something to it, sill? |
No I think it's a really good init! We can merge this and continue in other PRs. Thanks a lot! π |
π Linked issue
#546
β Type of change
π Description
The codebase is missing unit tests. This PR will add the test bench and some basic cases from where to start expanding the test base. The tests now test that the module setup works correctly. Next step would be to add tests for components.
π Checklist