-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module): add support for vue
using unplugin
#2416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui3 with Β Β Cloudflare Pages
|
commit: |
Wouldn't this also work for pnpm (I'm not using pnpm much and haven't tried)?
I think this is a better option, because it does not affect all packages, but also doesn't need users to manually update Tailwind/vue-router/@unhead/vue. |
Closed
benjamincanac
approved these changes
Oct 25, 2024
Thanks again @danielroe! β€οΈ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #2129
β Type of change
π Description
This adds support for using Nuxt UI using Vue. It's been built in an abstract way with unplugin so that conceivably this could run for non-vite-based projects.
Note: added
fast-deep-equal
as an explicit dependency as it was previously an implicit dependency of Nuxt.π Usage
You can test the PR with https://github.com/danielroe/nuxt-ui-vue (using the power of pkg.pr.now), or follow these steps:
vite.config.ts
{lang="ts-type"}:unplugin-auto-import
andunplugin-vue-components
, which will generateauto-imports.d.ts
andcomponents.d.ts
type declaration files. You will likely want to gitignore these, and add them to yourtsconfig
.App.vue
or CSS:Warning
If you're using pnpm, ensure that you either set
shamefully-hoist=true
in your.npmrc
file or installtailwindcss@next
,vue-router
and@unhead/vue
directly in your project's root directory.π§ TODO
app.config.ts
in rootDir and support passing config directly via options in unplugintailwindcss@alpha
,vue-router
and@unhead/vue
.gitignore
andtsconfig.app.json
investigate if we need to supportsize
prop for@iconify/vue