Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): display banner when running with compatibilityVersion #27305

Merged
merged 2 commits into from
May 23, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 22, 2024

🔗 Linked issue

resolves #27302

📚 Description

When users are running Nuxt with a different compatibilityVersion than the current one, this adds a banner.

CleanShot 2024-05-22 at 17 53 31@2x

Wording improvements are particularly welcome 🙏

Copy link

stackblitz bot commented May 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member Author

cc: @pi0 in case you think it's better in nuxt/cli, but I figured that this is very much tied to the nuxt instance itself and its options, which might be manipulated by modules (e.g. not like Nuxt/Nitro versions which CLI can resolve).

Co-authored-by: Alexander Lichter <[email protected]>
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (perhaps a shortlink in mesage to docs could be helpful for future notes and updates?)

@danielroe
Copy link
Member Author

Okay - let's definitely do that then. Merging this and will update once I create the short link. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show compatibility flag when starting the server
3 participants