Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs page for prerendering #27286

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

RyanClementsHax
Copy link
Contributor

🔗 Linked issue

Resolves #22011

📚 Description

Copy link

stackblitz bot commented May 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@RyanClementsHax
Copy link
Contributor Author

@danielroe I had a few follow up questions related to this comment.

  • Are there any examples of this? "mention 200.html + 404.html and the need to set these up as fallbacks (e.g. on S3)"
  • Is there a list of features to menation here? "mention static builds and providers that support it with extra features (like vercel, netlify, amplify + cloudflare pages)"
  • Do you know off the top of your head what takes precedence with all of the different ways to configure prerendering?

I'll happily make any changes you would like for you. This is just the first draft.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice - thank you! ❤️

Copy link
Member

atinux commented May 22, 2024

I love it, thank you ❤️

@RyanClementsHax
Copy link
Contributor Author

@danielroe @atinux thanks for your kind words :)

Any other changes you would like to see?

@danielroe danielroe merged commit b3f519a into nuxt:main Jun 10, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
4 tasks
@RyanClementsHax
Copy link
Contributor Author

@danielroe Thanks for taking my contribution! I think there were still some open items you wanted in #22011 (comment). Would you like me to create a new PR for those? I just need some clarification what you meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation Request] Prerender section
3 participants