feat: Adds logic to enable secure URLs in the imgix provider #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danny-pearson thanks for the PR. I think we need a mechanism like a runtime config to pass the token. Since options are directly added to runtime/providers which is bundled as a part of client-code (this means someone can easily gain token to sign their URLs) |
|
@pi0 Aye I'm not ganna lie that completely slipped my mind baha :/ I'll have a look at getting that sorted this weekend :) |
|
We may use new provider setup hooks to inject token to |
|
I've moved this topic to #276. Thanks for the initiative @danny-pearson 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Imgix provider to sign the image url using the token provided when 'Secure URLs' is enabled in the source. The token can be passed in as an option to the provider in
nuxt.config...This also lets you use images that are served from a web proxy source without having to sign them manually or rely on another dependency :)