This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(bridge): Recognize {... as default } construction in vite plugin #1769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Currently, the construction
export { xyz as default }
is not recognized as a valid default export by the default-export vite plugin. Thus, a second default export is added, which leads to an error.An example is
https://github.com/posva/pinia/blob/a76e34387419e86154a63985ad038eefeb2bc9fd/packages/nuxt/src/templates/plugin.ts#L50
which is transpiled as
export { PiniaNuxtPlugin as default };
in the distributed build. (cc @posva)This is fixed by adding a regex-based check.
π Checklist