Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing pinia store modules #751

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

webfansplz
Copy link
Contributor

πŸ”— Linked issue

Be related to vuejs/devtools#693
Close #724

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@antfu antfu merged commit be243e4 into nuxt:main Nov 20, 2024
2 checks passed
@martinszeltins
Copy link

@antfu @webfansplz Can someone explain what exactly the issue was? There is no helpful description on this PR and looking at the changes it is not clear what exactly the bug was or how it was fixed. I would appreciate some explanation.

@webfansplz
Copy link
Contributor Author

@antfu @webfansplz Can someone explain what exactly the issue was? There is no helpful description on this PR and looking at the changes it is not clear what exactly the bug was or how it was fixed. I would appreciate some explanation.

In simple terms, the latest version of the Vue Devtools browser extension added a feature to lazily load Devtools plugins to improve the performance. This optimization affected Nuxt Devtools. The main change in this PR is to notify the Devtools kit to start loading the Devtools plugin when the Devtools panel is opened to fix the issue.

@webfansplz webfansplz deleted the fix-pinia-panel branch November 20, 2024 10:08
@martinszeltins
Copy link

@antfu @webfansplz Can someone explain what exactly the issue was? There is no helpful description on this PR and looking at the changes it is not clear what exactly the bug was or how it was fixed. I would appreciate some explanation.

In simple terms, the latest version of the Vue Devtools browser extension added a feature to lazily load Devtools plugins to improve the performance. This optimization affected Nuxt Devtools. The main change in this PR is to notify the Devtools kit to start loading the Devtools plugin when the Devtools panel is opened to fix the issue.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help: Pinia stores are empty in devtools
3 participants