use router basepath in client plugin #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix #52 by building the fetch URI using publicPath and router.base
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 93.41% 92.41% -1.00%
==========================================
Files 13 13
Lines 410 422 +12
Branches 76 79 +3
==========================================
+ Hits 383 390 +7
- Misses 24 29 +5
Partials 3 3
Continue to review full report at Codecov.
|
atinux
requested changes
Jun 3, 2020
|
Will try locally when on the computer, thanks @campino2k |
chrisjung-dev
commented
Jun 3, 2020
atinux
approved these changes
Jun 9, 2020
pi0
pushed a commit
that referenced
this pull request
Feb 8, 2022
pi0
pushed a commit
that referenced
this pull request
Feb 8, 2022
* use @docus/mdc * feat: context template * fix: test * chore: update lock file * fix: static generate * fix: rename template * chore: update @docus/mdc * fix: CI test * fix: remark plugins
pi0
pushed a commit
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #52 by building the fetch URI using publicPath and router.base