Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect type for fetch which returns a promise #518

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix: Incorrect type for fetch which returns a promise #518

merged 1 commit into from
Oct 1, 2020

Conversation

nielsdB97
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The type for QueryBuilder#fetch (introduced in #444) is defined as a synchronous method. However it is not, because it returns a Promise.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why) – there are no tests for the types

@nielsdB97 nielsdB97 changed the title Fix type for fetch returning a promise fix: Incorrect type for fetch which returns a promise Sep 29, 2020
@mathe42
Copy link
Contributor

mathe42 commented Sep 30, 2020

Yes you are correct...

@benjamincanac benjamincanac merged commit 7f590f6 into nuxt:dev Oct 1, 2020
benjamincanac pushed a commit that referenced this pull request Oct 12, 2020
@nielsdB97 @benjamincanac
fix: Incorrect type for fetch which returns a promise (#518)
c20345a
@nielsdB97 nielsdB97 deleted the patch-1 branch February 23, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathe42 mathe42 mathe42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdB97 @mathe42 @benjamincanac