Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): fix tab key handling of editor component with IME #509

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix(content): fix tab key handling of editor component with IME #509

merged 1 commit into from
Oct 1, 2020

Conversation

clomie
Copy link

@clomie clomie commented Sep 27, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

I often use tab key to composition string from the suggested clauses with IME, but using on editor.vue occurs unexpected behavior.
This PR is to avoid tab key handling on the editor.vue during text composition session.

Before After
before after

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Testing event handling is a bit hard..., but l can try to add it so please let me know if it's needed.

@benjamincanac benjamincanac merged commit 1224ee6 into nuxt:dev Oct 1, 2020
@clomie clomie deleted the feat/prevent-keydown-in-composition branch October 5, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants