-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent options merging fn exec without default value #287
Conversation
~ |
Codecov Report
@@ Coverage Diff @@
## dev #287 +/- ##
======================================
Coverage ? 90.21%
======================================
Files ? 15
Lines ? 552
Branches ? 118
======================================
Hits ? 498
Misses ? 48
Partials ? 6 Continue to review full report at Codecov.
|
|
Never mind I was wrong... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* fix(lib): prevent options merging fn exec without default value * test: fix extend parser options test
Functions in configuration are meant to allow merging default values. Now, functions are only executed if the value already exists in the configuration.
Types of changes
Description
When using
extendParser
with a function'.txt': (file) => ({ body: file })
, the function was executed.