Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support markdown excerpt #250

Closed
wants to merge 9 commits into from
Closed

Conversation

benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Jul 10, 2020

Support Markdown excerpt.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

benjamincanac and others added 9 commits July 10, 2020 15:49
* fix(lib): use compound sort

* fix(lib): plugin sends sorts in wrong order

* test: add with multiple sorts
* docs: update github link to dev branch

* Properly handle anchor tags without href fields (#230)

* chore(deps): update dependency @nuxt/static to ^0.0.12 (#234)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps): update devdependency sass-loader to ^9.0.2 (#235)

Co-authored-by: Renovate Bot <[email protected]>

* fix: use compound sort (#238)

* fix(lib): use compound sort

* fix(lib): plugin sends sorts in wrong order

* test: add with multiple sorts

* chore(deps): update dependency @nuxt/static to v1 (#242)

Co-authored-by: Renovate Bot <[email protected]>

* chore: add content:ready hook (#243)

* translate configuration.md into japanese

* add playground.md in ja

* add integrations.md in ja

* add examples.md in ja

* edit fetching.md

* translate wriging.md in ja

* update theme.md front matter in ja

* translate advanced.md in ja

* fix a bit

* edit front matter

* add translation

Co-authored-by: Benjamin Canac <[email protected]>
Co-authored-by: Philip E Blair <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
@benjamincanac benjamincanac linked an issue Jul 10, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #250 into dev will decrease coverage by 0.24%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
- Coverage   89.56%   89.31%   -0.25%     
==========================================
  Files          15       15              
  Lines         527      543      +16     
  Branches      107      112       +5     
==========================================
+ Hits          472      485      +13     
- Misses         48       51       +3     
  Partials        7        7              
Impacted Files Coverage Δ
lib/parsers/markdown/index.js 86.04% <66.66%> (-1.76%) ⬇️
lib/middleware.js 82.43% <75.00%> (-2.08%) ⬇️
lib/index.js 77.01% <100.00%> (+0.54%) ⬆️
lib/parsers/markdown/compilers/json.js 100.00% <100.00%> (ø)
lib/query-builder.js 98.92% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4b884...7136838. Read the comment docs.

@benjamincanac benjamincanac force-pushed the dev branch 2 times, most recently from 8adaeb2 to d36a9e8 Compare July 27, 2020 12:11
@kylewelsby
Copy link
Contributor

It appears this feature is not in dev anymore.

Any reason why? Would be ideal to support this.

I'll open up a Pull Request if needed.

@kylewelsby
Copy link
Contributor

I opened a Pull request #607 that re-introduces this feature.

@atinux atinux deleted the feat/markdown-excerpt branch March 8, 2022 14:53
@atinux atinux restored the feat/markdown-excerpt branch March 8, 2022 14:53
@atinux atinux deleted the feat/markdown-excerpt branch March 8, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content excerpt support
5 participants