Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join array props #248

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix: join array props #248

merged 1 commit into from
Jul 13, 2020

Conversation

benjamincanac
Copy link
Member

Resolves #247.

Fix array props rendering of JSON AST to HTML.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@benjamincanac benjamincanac requested a review from atinux July 10, 2020 15:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@4901648). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #248   +/-   ##
======================================
  Coverage       ?   89.46%           
======================================
  Files          ?       15           
  Lines          ?      541           
  Branches       ?      111           
======================================
  Hits           ?      484           
  Misses         ?       50           
  Partials       ?        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4901648...8f97417. Read the comment docs.

@benjamincanac benjamincanac merged commit bcf26c3 into dev Jul 13, 2020
@benjamincanac benjamincanac deleted the fix/component-array-props branch July 13, 2020 08:47
benjamincanac added a commit that referenced this pull request Jul 20, 2020
benjamincanac added a commit that referenced this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External link syntax generates rel with comma separated values - is this expected?
3 participants