feat: add XML support #182

mathe42 · 2020-06-26T09:55:09Z

adding Support for XML files

codecov-commenter · 2020-06-26T09:58:00Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@e7d9c7e). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #182   +/-   ##
======================================
  Coverage       ?   89.40%           
======================================
  Files          ?       15           
  Lines          ?      519           
  Branches       ?      106           
======================================
  Hits           ?      464           
  Misses         ?       48           
  Partials       ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d9c7e...423d12e. Read the comment docs.

benjamincanac · 2020-06-26T10:01:12Z

Hey @mathe42,

Thanks for this PR!

Could you also:

add in example/content an XML file to demonstrate like the other formats in example/pages/index.vue
add in test/fixture/content/formats an XML file to ensure parsing works
add in docs/content/en/writing.md a section about XML format

mathe42 · 2020-06-26T10:44:16Z

Jap. Will work on that.

mathe42 · 2020-06-26T10:59:10Z

@benjamincanac
All done.

benjamincanac

Looks good to me! However, I can't install it locally, xml2json seems to use node-expat which causes a build error on Mac OS.

I can't merge this until this issue is solved, do you have and idea on this?

There is an issue related: buglabs/node-xml2json#190

benjamincanac · 2020-06-26T14:41:52Z

Actually there are still tiny things missing:

In docs/en/configuration.md, could you add a section like for the yaml: https://content.nuxtjs.org/configuration#yaml
In lib/utils.js, could you add xml to the defaults

mathe42 · 2020-06-26T15:36:40Z

I can nearly switch to any xml Parser I will look into https://github.com/Leonidas-from-XIV/node-xml2js

mathe42 · 2020-06-26T16:38:28Z

@benjamincanac Now it should work. I changed the parser.

mathe42 · 2020-06-26T16:38:56Z

Documentiation is updated.

benjamincanac · 2020-06-29T13:23:47Z

@mathe42 Perfect! Thanks 😃

* feat: global components (#164) * feat(lib): register nuxt components:dirs hook * chore(deps): use nuxt v2.13.x * chore(example): use global components * chore(docs): use global components * docs: add section about global components * Update docs/package.json Co-authored-by: Sébastien Chopin <[email protected]> * docs: update global components * Update writing.md * chore: remove commitlint * docs: update deps * chore(deps): update * chore(github): add ci on dev branch Co-authored-by: Sébastien Chopin <[email protected]> * chore(deps): update lock * chore(github): add ci on macos * feat: plugins compatibility (#183) * feat(lib): backwards compatibility with `plugins` and `basePlugins` * docs: update for v1.4.0 instead of v2.0.0 * chore(deps): update dependency consola to ^2.14.0 (#184) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update devdependency nuxt to ^2.13.2 (#186) Co-authored-by: Renovate Bot <[email protected]> * feat: handle middleware `where` query params (#190) * feat(lib): handle where query params * chore(example): add links * test: add middleware where query params * docs: add section for where query params * feat: add XML support (#182) * add xml file * add xml * add dependencies * Update index.js * bugfix * Create xml.xml * Update index.vue * Create xml.xml * Update writing.md * Update writing.md * Update utils.js * fix dependencies * fix * update docs * add config docs * Update index.md Co-authored-by: Benjamin Canac <[email protected]> * docs: clean writing codeblocks Co-authored-by: Sébastien Chopin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Sebastian Krüger <[email protected]>

* feat: global components (#164) * feat(lib): register nuxt components:dirs hook * chore(deps): use nuxt v2.13.x * chore(example): use global components * chore(docs): use global components * docs: add section about global components * Update docs/package.json Co-authored-by: Sébastien Chopin <[email protected]> * docs: update global components * Update writing.md * chore: remove commitlint * docs: update deps * chore(deps): update * chore(github): add ci on dev branch Co-authored-by: Sébastien Chopin <[email protected]> * chore(deps): update lock * chore(github): add ci on macos * feat: plugins compatibility (#183) * feat(lib): backwards compatibility with `plugins` and `basePlugins` * docs: update for v1.4.0 instead of v2.0.0 * chore(deps): update dependency consola to ^2.14.0 (#184) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update devdependency nuxt to ^2.13.2 (#186) Co-authored-by: Renovate Bot <[email protected]> * feat: handle middleware `where` query params (#190) * feat(lib): handle where query params * chore(example): add links * test: add middleware where query params * docs: add section for where query params * feat: add XML support (#182) * add xml file * add xml * add dependencies * Update index.js * bugfix * Create xml.xml * Update index.vue * Create xml.xml * Update writing.md * Update writing.md * Update utils.js * fix dependencies * fix * update docs * add config docs * Update index.md Co-authored-by: Benjamin Canac <[email protected]> * docs: clean writing codeblocks * chore(deps): update all non-major dependencies to ^7.10.4 (#198) Co-authored-by: Renovate Bot <[email protected]> * docs: (en) add example for toc (#196) add an example for table of contents usage * chore(deps): update devdependency @nuxtjs/module-test-utils to ^1.6.2 (#203) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency p-queue to v6.5.0 (#204) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): try nuxt static * docs: add code of conduct * docs: add pull request template * docs: update readme * chore(pkg): rename to generate * chore(deps): update devdependency @nuxtjs/module-test-utils to ^1.6.3 (#205) Co-authored-by: Renovate Bot <[email protected]> * docs: improve (#206) * docs: update * docs: update * docs: update * docs: update design * docs: update markdown titles scroll position * docs: small improvements * docs: add clipboard * docs: update copy style Co-authored-by: Sébastien Chopin <[email protected]> * Add "without" method to type declaration (#208) * docs: typo + translate EN leftover (#207) Co-authored-by: Sébastien Chopin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Sebastian Krüger <[email protected]> Co-authored-by: Debbie O'Brien <[email protected]> Co-authored-by: Luke Wiwatowski <[email protected]> Co-authored-by: jbuiquan <[email protected]>

* add xml file * add xml * add dependencies * Update index.js * bugfix * Create xml.xml * Update index.vue * Create xml.xml * Update writing.md * Update writing.md * Update utils.js * fix dependencies * fix * update docs * add config docs * Update index.md Co-authored-by: Benjamin Canac <[email protected]>

mathe42 added 5 commits June 26, 2020 11:25

add xml file

464c501

add xml

1e05599

add dependencies

587fdc3

Update index.js

4ad5d56

bugfix

1ee9114

mathe42 changed the title ~~add XML support~~ feat: add XML support Jun 26, 2020

mathe42 added 5 commits June 26, 2020 12:46

Create xml.xml

4493335

Update index.vue

1a8cd47

Create xml.xml

6dc7d42

Update writing.md

40ba2aa

Update writing.md

41a1b98

benjamincanac changed the base branch from master to dev June 26, 2020 14:07

Merge branch 'dev' into pr/182

df85b08

benjamincanac requested changes Jun 26, 2020

View reviewed changes

Merge branch 'dev' into pr/182

e142d47

mathe42 added 6 commits June 26, 2020 17:38

Update utils.js

ebd410c

fix dependencies

0e3b745

fix

1354d5d

Merge branch 'master' of https://github.com/mathe42/content

f4c7002

update docs

e82ee02

add config docs

42bec0f

mathe42 requested a review from benjamincanac June 27, 2020 20:26

Update index.md

423d12e

benjamincanac approved these changes Jun 29, 2020

View reviewed changes

benjamincanac merged commit d334f1e into nuxt:dev Jun 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add XML support #182

feat: add XML support #182

mathe42 commented Jun 26, 2020 •

edited

Loading

codecov-commenter commented Jun 26, 2020 •

edited

Loading

benjamincanac commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

benjamincanac left a comment •

edited

Loading

benjamincanac commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

benjamincanac commented Jun 29, 2020

feat: add XML support #182

feat: add XML support #182

Conversation

mathe42 commented Jun 26, 2020 • edited Loading

codecov-commenter commented Jun 26, 2020 • edited Loading

Codecov Report

benjamincanac commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

benjamincanac left a comment • edited Loading

Choose a reason for hiding this comment

benjamincanac commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

mathe42 commented Jun 26, 2020

benjamincanac commented Jun 29, 2020

mathe42 commented Jun 26, 2020 •

edited

Loading

codecov-commenter commented Jun 26, 2020 •

edited

Loading

benjamincanac left a comment •

edited

Loading