Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate markdown component #1435

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

resolves #1434

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [] πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 12, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 3c645e2
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62fb5e9abaa2d70008f0c756
😎 Deploy Preview https://deploy-preview-1435--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
Copy link
Member

atinux commented Aug 12, 2022

Following the discussion in #1434

In that case I prefer to name it <ContentSlot /> directly, the idea of naming it <RichSlot /> was that it is actually a<slot/> but with the unwrap capability.

@farnabaz farnabaz merged commit 28c49c0 into main Aug 16, 2022
@farnabaz farnabaz deleted the chore/deprecate-markdown-component branch August 16, 2022 15:12
@farnabaz farnabaz mentioned this pull request Sep 2, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename <Markdown> to <RichSlot>
2 participants