Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source): allow overwriting default source #1273

Merged
merged 9 commits into from
Jun 22, 2022
Merged

feat(source): allow overwriting default source #1273

merged 9 commits into from
Jun 22, 2022

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jun 20, 2022 •
edited
Loading

🔗 Linked issue

resolves #1264

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 20, 2022 •
edited
Loading

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit 2253d30
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62b2dd5e1a4ffc0009f009a5
😎 Deploy Preview https://deploy-preview-1273--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
Copy link
Member

atinux commented Jun 20, 2022

Can we also take this opportunity to move also to the object syntax (and warn for array syntax)?

atinux
atinux reviewed Jun 21, 2022
View reviewed changes
atinux
atinux reviewed Jun 21, 2022
View reviewed changes
atinux
atinux reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments, overall seems good to me 👍

@farnabaz farnabaz merged commit c21f5f1 into main Jun 22, 2022
@farnabaz farnabaz deleted the feat/overwrite-default-source branch June 22, 2022 09:21
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz added a commit that referenced this pull request Sep 7, 2022
@farnabaz @atinux
feat(source): allow overwriting default source (#1273)
ed69346 
* feat(source): allow overwriting default source

* feat: sources object syntax

* chore: update nuxt config

* test: add test

* docs: fix build

* Apply suggestions from code review

Co-authored-by: Sébastien Chopin <[email protected]>

* fix: respect source name

* chore: remove log

Co-authored-by: Sébastien Chopin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overwriting default content source
2 participants
@farnabaz @atinux