Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow ws config #1249

Merged
merged 3 commits into from
Jun 14, 2022
Merged

feat(config): allow ws config #1249

merged 3 commits into from
Jun 14, 2022

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented Jun 13, 2022

πŸ”— Linked issue

#1244

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #1244

Allow user to change WebSocket port used, improving compatibility with Docker environments.

ws key is used for config, might be subject to changes based on @farnabaz review.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 13, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit e97622c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62a75f245aefb2000a1f1557
😎 Deploy Preview https://deploy-preview-1249--nuxt-content.netlify.app/playground
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/module.ts Outdated Show resolved Hide resolved
@Tahul Tahul requested a review from farnabaz June 13, 2022 16:00
@Tahul Tahul merged commit 6c903de into main Jun 14, 2022
@Tahul Tahul deleted the feat/ws-config branch June 14, 2022 09:22
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
* feat(config): allow ws config

* feat(ws): allow ws configuration from `watch` key

* chore(playground): prune playground content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can specify a port of the dev ws
2 participants