Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(markdown): allow overwriting plugins #1226

Merged
merged 9 commits into from
Jun 9, 2022
Merged

feat(markdown): allow overwriting plugins #1226

merged 9 commits into from
Jun 9, 2022

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jun 7, 2022 •
edited by Tahul
Loading

🔗 Linked issue

resolves #1212

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 7, 2022 •
edited
Loading

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit 36a2e2a
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62a1e0be7307f30009532701
😎 Deploy Preview https://deploy-preview-1226--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Tahul
Tahul suggested changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey :), this is excellent work!

Could you tell if it is possible to test this case?

Like testing each possible way to import/update/overwrite plugins configurations?

That would also be really helpful for me to update the documentation.

@Tahul
Copy link
Contributor

Tahul commented Jun 9, 2022

Great job @farnabaz, LGTM now :)

We'll just need to open an issue to track support for local remark/rehype plugins.

farnabaz
farnabaz commented Jun 9, 2022
View reviewed changes
Copy link
Member Author

@farnabaz farnabaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: remove unused links

@farnabaz farnabaz merged commit ede65e8 into main Jun 9, 2022
@farnabaz farnabaz deleted the feat/overwrite-md-plugins branch June 9, 2022 12:04
@Benbinbin Benbinbin mentioned this pull request Jul 21, 2022
Open
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz added a commit that referenced this pull request Sep 7, 2022
@farnabaz @Tahul
feat(markdown): allow overwriting plugins (#1226)
35df339 
Co-authored-by: Yaël Guilloux <[email protected]>
@alexanderhorner
Copy link

Hey, do you know wich plugins adds the links on headings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tahul Tahul Tahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't override default plugins
3 participants
@farnabaz @Tahul @alexanderhorner