Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): allow navigation opt-out with navigation: false #1208

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

harlan-zw
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The documentation says

Set navigation: false in the front-matter of a page to exclude it in fetchContentNavigation() return value.

However, it doesn't work. I couldn't find any logic for excluding this. The Example on the page is even showing the wrong data.

This change properly filters out the pages with this setting from the navigation query.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 3, 2022

‼️ Deploy request for nuxt-content rejected.

Name Link
πŸ”¨ Latest commit 200027e

@Tahul
Copy link
Contributor

Tahul commented Jun 3, 2022

Hey πŸ‘‹,

This is a bad mistake from myself, this behavior is actually implemented into Docus and not Content module 🀦

Thank you so much for fixing that!

@Tahul Tahul merged commit bda0cd0 into nuxt:main Jun 3, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
…1208)

* fix(navigation): allow navigation opt-out with `navigation: false`

* fix: use existing where query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants