Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: spell extensions correctly #1204

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Jun 3, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The key is spelled incorrectly, as someone who is adding a custom transformer I'd prefer not to have misspelled keys in my code.

BREAKING CHANGE: custom transformers should rename key extentions to extensions

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

BREAKING CHANGE: custom transformers should rename key `extentions` to  `extensions`
@netlify
Copy link

netlify bot commented Jun 3, 2022

‼️ Deploy request for nuxt-content rejected.

Name Link
πŸ”¨ Latest commit 4a68090

@Tahul
Copy link
Contributor

Tahul commented Jun 3, 2022

I'll let @farnabaz double-check this one but this LGTM. πŸ˜„

I don't think a lot of people actually uses custom transformers in their own projects yet, so even if this adds a breaking change it is fine to me to push this ASAP.

Thank you so much @harlan-zw

@Tahul Tahul requested a review from farnabaz June 3, 2022 12:05
@Tahul Tahul merged commit adc0143 into nuxt:main Jun 3, 2022
@pi0
Copy link
Member

pi0 commented Jun 3, 2022

Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major.

@harlan-zw
Copy link
Contributor Author

Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major.

Thanks for the review @pi0, you're absolutey right. A soft fix would have been a better option. I'll avoid these type of PRs in the future πŸ‘

@pi0
Copy link
Member

pi0 commented Jun 4, 2022

No worries! Is current change released? If not we might have a chance to avoid breaking.

harlan-zw added a commit to harlan-zw/nuxt-content-fork that referenced this pull request Jun 5, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants