-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: spell extensions
correctly
#1204
Conversation
BREAKING CHANGE: custom transformers should rename key `extentions` to `extensions`
|
Name | Link |
---|---|
π¨ Latest commit | 4a68090 |
I'll let @farnabaz double-check this one but this LGTM. π I don't think a lot of people actually uses custom transformers in their own projects yet, so even if this adds a breaking change it is fine to me to push this ASAP. Thank you so much @harlan-zw |
Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major. |
Thanks for the review @pi0, you're absolutey right. A soft fix would have been a better option. I'll avoid these type of PRs in the future π |
No worries! Is current change released? If not we might have a chance to avoid breaking. |
This reverts commit adc0143.
π Linked issue
β Type of change
π Description
The key is spelled incorrectly, as someone who is adding a custom transformer I'd prefer not to have misspelled keys in my code.
BREAKING CHANGE: custom transformers should rename key
extentions
toextensions
π Checklist