Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): more accurately represent ParsedContentMeta #1196

Merged
merged 5 commits into from
Jun 3, 2022
Merged

fix(types): more accurately represent ParsedContentMeta #1196

merged 5 commits into from
Jun 3, 2022

Conversation

harlan-zw
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • _slug is not used but is in the types, which is misleading
  • full list of id types (_type, _file, _extension) are missing
  • added types to the path-meta file to ensure stricter type adherence

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 2, 2022 •
edited
Loading

‼️ Deploy request for nuxt-content rejected.

Name Link
🔨 Latest commit 1591b6c

@harlan-zw harlan-zw changed the title Fix/improved meta types fix(types): more accurately represent ParsedContentMeta Jun 2, 2022
@Tahul Tahul merged commit 3fbcd22 into nuxt:main Jun 3, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
@harlan-zw @farnabaz
fix(types): more accurately represent ParsedContentMeta (#1196)
8e8eb34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tahul Tahul Tahul approved these changes

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harlan-zw @atinux @Tahul