Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): add redirects for v1 #1130

Merged
merged 4 commits into from
May 24, 2022
Merged

docs(migration): add redirects for v1 #1130

merged 4 commits into from
May 24, 2022

Conversation

clemcode
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds 302 redirects for v1 URLs

Ex:

/installation /v1/installation 302!
/:locale/installation /:locale/v1/installation 302!

@clemcode clemcode added the documentation Improvements or additions to documentation label May 24, 2022
@clemcode clemcode requested review from atinux and Tahul May 24, 2022 13:39
@netlify
Copy link

netlify bot commented May 24, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit a23ad5f
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/628d1239f898790008191725
😎 Deploy Preview https://deploy-preview-1130--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -0,0 +1,26 @@
# V1

/installation /v1/installation 302!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-05-24 at 15 57 33

I think we should update paths.

I updated the structure so we have exact same routes for each pages.

The redirections written here won't follow correct paths.

https://deploy-preview-1123--nuxt-content.netlify.app/v1/en/getting-started/installation

You can browse actual V1 routes there; the only exception is that routes will become:

/v1/getting-started/installation => default locale (en)
/:locale/v1/getting-started/installation => localized path (fr, ja, ..)

@Tahul Tahul merged commit 75a2e74 into main May 24, 2022
@Tahul Tahul deleted the docs/migration/redirects branch May 24, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants