Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try new full width fluid Container layout #730

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented Dec 16, 2022

To try this branch you need to use latest Elements commits (most likely locally using .docs/.env file with THEME_DEV_ELEMENTS_PATH={pwd to Elements repo}, until new Elements released) @atinux @Tahul

@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docus ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 8:18PM (UTC)

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Dec 21, 2022

I've updated deps, so there should be any bugs to preview it now @atinux

Copy link
Contributor

atinux commented Dec 22, 2022

It is looking great. But this becomes the new default?

Copy link
Contributor Author

bdrtsky commented Dec 22, 2022

@atinux if you ok with this layout, I will test it more (including bigger 4k screens). I guess it could be new default, but I can support both layouts, maybe add a setting into app.config? This small update changes layout pretty radically.

Copy link
Contributor

atinux commented Dec 22, 2022

What about this to activate it?

export default defineAppConfig({
  docus: {
    layout: 'fluid'
  }
})

Copy link
Contributor Author

bdrtsky commented Dec 22, 2022

yes, exactly, could be fluid | fixed. I will update PR to support both.

@bdrtsky bdrtsky requested a review from Tahul January 3, 2023 20:23
@bdrtsky bdrtsky merged commit af37f2e into dev Jan 3, 2023
@bdrtsky bdrtsky deleted the feat/new-container-layout branch January 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants