Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icons positioning #722

Merged
merged 6 commits into from
Dec 16, 2022
Merged

fix: icons positioning #722

merged 6 commits into from
Dec 16, 2022

Conversation

bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented Dec 12, 2022

Moving social icons & color mode switch from AppHeader to AppFooter, to leave place for Search icon and Navigation links in header (also those links/toggle is not very important to keep them in AppHeader imao)

This should also fix some Nuxt Content docs issues.

@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docus ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 4:19PM (UTC)

@bdrtsky bdrtsky requested a review from Tahul December 12, 2022 19:16
@Tahul
Copy link
Contributor

Tahul commented Dec 14, 2022

@atinux ; needs your inputs on this ?

I think the icons on the top right can become conflicting with other features (Search) while providing very low value to user.

I would maybe have kept the social icons (Twitter/GitHub, etc) in the header?

@R-mooon inputs would be great as well!

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Dec 14, 2022

I think social icons is not necessary in fixed header since they already present in 2 other places (mobile menu and footer). Being in fixed header they create almost no value (doubt someone will need fast access for them to go to docs Twitter page), and it looks like you desperately trying to create a lead from visitor by placing social icons all over the website, even showing them to user at every moment they're looking at page (strange for open source documentation page)

Copy link
Contributor Author

bdrtsky commented Dec 14, 2022

If social still necessary I would pick only GitHub icon to show in Header (keeping all others in less prominent places). This also will make UI more diverse (currently we basically cloning SocialIcons 3 times)

@atinux
Copy link
Contributor

atinux commented Dec 14, 2022

I strongly believe that on desktop, we should keep the icons on the top bar.

On mobile, I would vote for search and fallback to light/dark mode so it keeps balance with the hamburger menu on the left and centered logo.

@Tahul
Copy link
Contributor

Tahul commented Dec 14, 2022

I think social icons (github/twitter/others) has most value in top bar

Dark/light mode is something you usually select only once (and now is also a "global parameter" that your computer defines once and should automatically be detected by the website), I would keep it in second places like footer and mobile menu

I think we should have social icons + search slots in desktop header menu

@Tahul
Copy link
Contributor

Tahul commented Dec 15, 2022

Can you update the PR to implement combination of social icons + search slot @bdrtsky ?

@Tahul
Copy link
Contributor

Tahul commented Dec 15, 2022

nuxt/content#1739

Related

Copy link
Contributor Author

bdrtsky commented Dec 16, 2022

Updated @Tahul

@atinux atinux merged commit 7168e19 into dev Dec 16, 2022
@atinux atinux deleted the fix/icons-positioning branch December 16, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants