-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icons positioning #722
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think social icons is not necessary in fixed header since they already present in 2 other places (mobile menu and footer). Being in fixed header they create almost no value (doubt someone will need fast access for them to go to docs Twitter page), and it looks like you desperately trying to create a lead from visitor by placing social icons all over the website, even showing them to user at every moment they're looking at page (strange for open source documentation page) |
If social still necessary I would pick only GitHub icon to show in Header (keeping all others in less prominent places). This also will make UI more diverse (currently we basically cloning SocialIcons 3 times) |
I strongly believe that on desktop, we should keep the icons on the top bar. On mobile, I would vote for search and fallback to light/dark mode so it keeps balance with the hamburger menu on the left and centered logo. |
I think social icons (github/twitter/others) has most value in top bar Dark/light mode is something you usually select only once (and now is also a "global parameter" that your computer defines once and should automatically be detected by the website), I would keep it in second places like footer and mobile menu I think we should have |
Can you update the PR to implement combination of social icons + search slot @bdrtsky ? |
Related |
Updated @Tahul |
Moving social icons & color mode switch from AppHeader to AppFooter, to leave place for Search icon and Navigation links in header (also those links/toggle is not very important to keep them in AppHeader imao)
This should also fix some Nuxt Content docs issues.