fix: toc correctly reflects headings in a viewport #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This fixes #700 by adding deep watch option in
useScrollspy.ts
:from
to
Problem Previously
useScrollspy.ts
While visibleHeadings were correctly updated when it came into a viewport (by chekcing if
entry.isIntersecting
usingIntersectionObserver
API), the watch function below did not updated activeHeadings in some circumstances (like when there were no activeHeadings in a viewport)I tried adding deep option to the watch function and it fixed the problem (might be bad for performance?)
Note
It's my first time contributing to open source. Hope I'm not making any mistakes haha