feat: change slot definition #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxtlabs/docus/xFq41xwfGmSXvFzNAPe2pz6yFZGx |
|
Nice! We need to update the documentation + release as a breaking change (0.9.0) and let the Nuxt team update the new nuxtjs.org also |
|
I've updated usages in the docs and Syntax section. |
|
Sure; this will be shipped into next breaking release; 0.9.0. |
Tahul
suggested changes
Jul 11, 2021
There was a problem hiding this comment.
Hey @farnabaz 😄
I checked your PR, the new syntax looks great, and looks amazing when used with the Docus plugin!
I've found a problem on page "theme/components", that seem to indicate a problem there:
https://github.com/nuxtlabs/docus/blob/cf1e653299798b78c421018600ec88633be936db/src/core/runtime/utils.ts#L60
Could you take a look at that? 😄
|
Updated \cc @Tahul |
Tahul
added a commit
that referenced
this pull request
Jul 12, 2021
* 📝 (docs) update docs; add algolia docsearch in configuration * fix(layout): fix parents order in layout inheritance * fix: add fixed width to mobile aside (#515) * fix: multiple regressions (#516) * fix: margins for docs content * fix: multiple issues * feat: enhanced i18n (#517) * fix(Link): support locale path & improve attrs * fix(contentLocalePath): handle locale prefix * 🐛 (link) fix blank reeference (props.blank) * 🔖 (0.8.6) release 0.8.6 * 🐛 (prose-code-inline) allow line break (#519) * fix: scrollspy & scroll to top on click for Releases (#522) * fix: restrict inline syntax (#526) * fix: restrict inline syntax * fix: allow inline syntax inside span & links * feat: auto collapse when click on another section (#527) * init pr * ✨ (aside) restore collapse state on section toggle Co-authored-by: Yaël GUILLOUX <[email protected]> * 🐛 (nuxtjs.org) small responsive/sizing fixes * fix: prose nested lists (#529) * fix: prose nested lists * cleanup * fix: multiple style issues (#523) * fix: code block issues * update filename shortcut * feat: support slot to show between children (#525) * feat: support slot to show between children * fix: do not add `between` slot between inline nodes * feat: inline SVG logo on production (#528) * feat: inline svg icon on production * fix: import * chore: cleanup * feat: improve logo management, add default Logo component and shortcuts * chore: remove @nuxtjs/svg * chore: simplify markup Co-authored-by: Sébastien Chopin <[email protected]> * feat: SandBox Component (#518) * feat: SandBox Component * chore: minor fix * feat: init Tabs component; refactor CodeGroup * update Sandbox UI Co-authored-by: Sergey Bedritsky <[email protected]> * 📦 (deps) upgrade dependencies * 🐛 (aside) fix aside navigation collapsing * 🐛 (aside) fix social icons spacing at the right place * 🔖 (0.8.7) release 0.8.7 * 📦 (deps) upgrade deps (nuxt-image) * 🐛 (sandbox) fix sandbox component * feat: add custom scrollbar (#534) * fix: update mobile toc overflow from scroll to auto (#532) * 🔖 (0.8.8) release 0.8.8 * 📝 (deployment) update deployment to add npm cache * 🔖 (0.8.9) release 0.8.9 * 🐛 (aside) hover color only in large on aside nav item * init AppBanner (#536) * init AppBanner * ✨ (banner) edit defaults * 📝 (config) update configuration with banner arg Co-authored-by: Yaël GUILLOUX <[email protected]> * 🔖 (0.8.10) release 0.8.10 * 🔖 (0.8.11) release 0.8.11 * 🐛 (docs) update docs links (avoid errors while building..) * fix: Releases content overflow (#537) * fix: Releases content overflow * 🐛 (releases) only apply overflow-x-hidden Co-authored-by: Yaël GUILLOUX <[email protected]> * 🐛 (content) fix content links avoiding a longer build * 🔖 (0.8.12) release 0.8.12 * chore: reduce UX issues (lazy loading and jump) * fix: currentNav updated after page change Also disabled smart prefetch for lazy components in the meantime * chore: add isAsync too * fix: revert back to old collapse logic (#539) * ⏪ (collapse) revert back to old collapse logic * 🐛 (navigation) preserve uncollapsing for first visited category * 📌 (deps) pin vue to 2.6.14 * 🐛 (twitter) fix twitter component import * fix: set variables on SSR from asyncData * 🔖 (0.8.13) release 0.8.13 * 🔖 (0.8.14) release 0.8.14 * fix: resolve flash issue using render fucntion instead of template (#541) * feat: Docus loading screen * 🔖 (0.8.15) release 0.8.15 * fix: tokenise blogpost (#540) * feat: change slot definition (#535) * feat: change slot definition * feat: front matter style data * chore: update docs * docs: fix docs * chore: refactor data tokenizer * fix: typo * fix: invalid line detection * feat: use remark-github (#538) * feat(admin): admin improvements (#524) * wip: components playground * fix: switch to nuxt module for components preview * refactor(admin): modulize preview * refactor(admin): folder structure * chore: typo * feat(admin): embed windicss-analysis * chore: update notes * feat: config tab * feat: preview navigate to editor * fix(admin): reuse utils instance for windi analysis * chore: update deps * feat(admin): entry for windi analyzer * chore: clean up * Apply suggestions from code review Co-authored-by: Sébastien Chopin <[email protected]> * 🚨 (lint) no-console fix * chore: cleanup vite fix Co-authored-by: Sébastien Chopin <[email protected]> Co-authored-by: Yaël GUILLOUX <[email protected]> Co-authored-by: Ahad Birang <[email protected]> Co-authored-by: Sergey Bedritsky <[email protected]> Co-authored-by: Sébastien Chopin <[email protected]> Co-authored-by: Anthony Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
improved syntax
highlighted syntax
resolves nuxtlabs/vscode-mdc#1
Checklist: