-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mdv syntax #318
feat: mdv syntax #318
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxtlabs/docus/FsypZ2LkYzdVZ6yXN7PQM2gymKCd |
Updated with simpler syntax that we discussed @atinux Sadly, Scoped slots not working on SSR. @pi0 does resolve this issue in vuejs/vue#11963 and we should wait for upstream ([email protected]) |
What are the components with scoped slots we have? |
For now the issue applies to |
When looking at it is still uses props, do you have the link to the one using scoped slots? |
Any ETA for Vue release? EDIT: i just asked Evan, will comment when he answered |
He said then can do a quick release on Monday 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me.
Only comments refers to code style.
I think for such features, we definitely need comments. 😄
If you are not comfortable with writing comments I can totally understand, at least commenting what each function does could be really interesting for long term maintenance.
Obviously the upcoming usage of tests into Docus will also help with that but I think this needs to become a standard that we comment functions, even when only exposed internally.
Other than these little comments about code style, I think you did an amazing job @farnabaz and that you are paving the way among something bigger than we can understand yet! 😄
Can't wait to see this syntax used in our upcoming editor. 🥲
👏 👏 👏
I complete @Tahul on it, amazing work done for a powerful future! Could we use something like JS/TS docs comments as a standard + inline comment in function if necessary to explain some logic? |
Yeah, TSDoc is basically JSDoc without the need of specifying parameters as it is filled by typings. 😄 We basically need to comment every function, I'll help on that obviously. 😄 If I need to add a commit in each PR to fix typos and any language problem, that will be a pleasure for me. 🙏 |
Types of changes
Description
{yml}
---
(::: => :::: => :::::
instead of::::: => :::: => :::)
<Makrdown>
component updated to detect parent slot and render Content::
Resolves #314
Checklist: