Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update resolveContentConfig a bit and viewer logging #931

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

ineshbose
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Copy link

netlify bot commented Dec 25, 2024

βœ… Deploy Preview for nuxt-tailwindcss ready!

Name Link
πŸ”¨ Latest commit 78517a0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/676c4cf16ce2e10008363a0e
😎 Deploy Preview https://deploy-preview-931--nuxt-tailwindcss.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

what-the-diff bot commented Dec 25, 2024

PR Summary

  • Enhanced Path Checking with isAbsolute
    Our code now checks for absolute paths. This import from pathe allows us to better analyse and work with file and directory paths.

  • Optimized resolveContentConfig Function
    The resolveContentConfig function has been changed to use rootDir instead of srcDir. This adjustment paves the way for more consistent path handling.

  • Upgraded Path Resolution Logic
    We've improved our path resolution logic to consider whether a path is absolute. This roundup ensures a more complete understanding of how file paths operate within our system.

  • Augustmented Helper Function withSrcDir
    The withSrcDir function now has expanded logic for resolving paths. This enhancement adds stronger functionality and consistency to our path handling.

  • Aligned References to Use rootDir
    For the sake of consistency, we have corrected various references which previously used srcDir, to now use rootDir.

  • Renamed extensionFormat to formatExtensions
    We've improved clarity by refactoring the extensionFormat function into formatExtensions. This modification improves the ease of understanding what the code is accomplishing.

  • Uniform Path Resolution with rootDir
    All paths that were previously resolved with srcDir in the configuring process, are now resolved with rootDir. This transformation ensures more consistent handling of paths throughout the code.

@ineshbose ineshbose marked this pull request as ready for review December 25, 2024 18:22
@ineshbose ineshbose changed the title chore: update resolveContentConfig a bit chore: update resolveContentConfig a bit and viewer logging Dec 25, 2024
@ineshbose ineshbose merged commit 3a7a8a0 into main Dec 25, 2024
7 checks passed
@ineshbose ineshbose deleted the chore/resolve-paths branch December 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant