Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): use window.location.href to avoid ts error #432

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

olrtg
Copy link
Contributor

@olrtg olrtg commented Oct 2, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The problem:
CleanShot 2024-10-02 at 19 15 53@2x

The fix:
Use window.location.href. Ref: https://stackoverflow.com/q/75194714

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

netlify bot commented Oct 2, 2024

👷 Deploy request for nuxt-strapi-module pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 22aa561

@benjamincanac benjamincanac changed the title docs: use window.location.href instead of window.location to avoid typescript error docs(auth): use window.location.href to avoid typescript error Oct 3, 2024
@benjamincanac benjamincanac changed the title docs(auth): use window.location.href to avoid typescript error docs(auth): use window.location.href to avoid ts error Oct 3, 2024
@benjamincanac benjamincanac merged commit 3655c4e into nuxt-modules:dev Oct 3, 2024
@benjamincanac
Copy link
Member

Thanks! 😊

@olrtg olrtg deleted the use-window-location-href branch October 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants