Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): advise a minimal cookie config #378

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

NicolasBrondin
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Description

By using the default cookie configuration {} and not setting a maxAge, the cookie becomes a SessionCookie by default, which is not what most people want when deploying a website! I just added some minimal configuration in the authentication docs.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Using the default cookie config {}, the cookie expiration is set to "Session" which is not what people want went they deploy a website!

Tried to help having a more complete doc on that side
Copy link

nuxt-studio bot commented Dec 21, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Strapi Edit on Studio ↗︎ View Live Preview aee760d

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for nuxt-strapi-module ready!

Name Link
🔨 Latest commit b377237
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-strapi-module/deploys/65a2dad1ee76ec0008c19cdb
😎 Deploy Preview https://deploy-preview-378--nuxt-strapi-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjamincanac benjamincanac changed the title Changed docs to advise a minimal cookie config and avoid session cookie docs(auth): advise a minimal cookie config Jan 13, 2024
@benjamincanac benjamincanac merged commit 0efe830 into nuxt-modules:dev Jan 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants