fix(useStrapiClient): import dns module only in development
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses the warning related to the "dns" module externalization for browser compatibility in the useStrapiClient.mjs file. The warning appeared during the Vite resolve process, and this change ensures that the "dns" module is imported conditionally only in a server environment during development. This modification aligns with best practices for handling browser-incompatible modules and resolves the warning mentioned in the Vite troubleshooting guide. Please review and merge at your earliest convenience. If there are any specific guidelines or adjustments needed, feel free to provide feedback. Thank you!
✅ Deploy Preview for nuxt-strapi-module canceled.
|
benjamincanac
approved these changes
Nov 28, 2023
benjamincanac
changed the title
dns module only in development
|
Thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the warning related to the "dns" module externalization for browser compatibility in the useStrapiClient.mjs file. The warning appeared during the Vite resolve process, and this change ensures that the "dns" module is imported conditionally only in a server environment during development. This modification aligns with best practices for handling browser-incompatible modules and resolves the warning mentioned in the Vite troubleshooting guide.
Please review and merge at your earliest convenience. If there are any specific guidelines or adjustments needed, feel free to provide feedback. Thank you!
Types of changes
Description
Checklist: