Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecated usage of useStrapi4 + missing old tailwind classes #327

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jiblett1000
Copy link
Contributor

@jiblett1000 jiblett1000 commented Mar 7, 2023

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Couple small changes:

  1. Updated the docs to change use of the deprecated useStrapi4 composable to useStrapi.

  2. It seems that tailwind was removed from docus at some point, but was still being used to style the badge container(s). It was also used to style Strapi in the hero title. I'm not sure if that's still wanted and you might want to change the .strapi-title class name or remove that coloring all together. I at least just wanted to bring these style issues to light.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@nuxt-studio
Copy link

nuxt-studio bot commented Mar 7, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Strapi Edit on Studio ↗︎ View Live Preview 39c4e29

@benjamincanac benjamincanac changed the title Doc fixes docs: deprecated usage of useStrapi4 + missing old tailwind classes Mar 8, 2023
@benjamincanac benjamincanac merged commit df4a189 into nuxt-modules:dev Mar 8, 2023
@benjamincanac
Copy link
Member

@jiblett1000 Thanks for the PR! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants