Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This is a small but important change. This separates the guard logic in the
fetchUser
method so that it maintains the current functionality while allowing the developer to refetch the user data when/if desired.By putting
if (!user)
around the fetchUser call in the plugin we maintain that it will only be called once when there is no user state. Then, we we leave theif (token)
within the fetchUser method to maintain security.Use case:
While building a profile page, I needed to update the user avatar and info. The avatar in particular posed a bigger problem. I needed to refresh the user info after uploading it. However, after banging my head against the wall for a bit while trying to use the
fetchUser
method, I realized the!user.value
guard in the method meant that it would never refetch the user data when a user was logged in. I moved that logic to the plugin and bingo, the avatar refreshed as intended.That's about it. Thanks for reading!
Checklist: