Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): support server-specific runtime configuration #247

Merged
merged 3 commits into from
May 25, 2022
Merged

feat(module): support server-specific runtime configuration #247

merged 3 commits into from
May 25, 2022

Conversation

doseofted
Copy link
Contributor

@doseofted doseofted commented May 17, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This allows server-side requests to make use of a separate URL by making full use of runtimeConfig in Nuxt. For instance, I may access a locally-running Strapi instance server-side at http://strapi-instance:1337 while client-side I would use https://strapi.example.com.

This is a functionality that has been very helpful in containerized environments, provided as an option by modules like nuxt/axios in Nuxt2.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I was unable to find tests within the repository.

@doseofted doseofted marked this pull request as ready for review May 17, 2022 19:54
@benjamincanac benjamincanac changed the title Server-specific runtime configuration can now be used feat(module): support server-specific runtime configuration May 25, 2022
@benjamincanac benjamincanac merged commit 3ee5b2a into nuxt-modules:dev May 25, 2022
@benjamincanac
Copy link
Member

Thanks @doseofted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants