refactor: split runtime types #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
force-pushed
the
refactor/runtime-types
branch
from
e046cc1 to
6cbf56b
Compare
pi0
commented
Jan 14, 2022
| @@ -19,7 +51,7 @@ export default defineNuxtModule<StrapiOptions>({ | |||
| version: 'v4', | |||
| cookie: {} | |||
| }, | |||
| setup (options: StrapiOptions, nuxt: Nuxt) { | |||
| setup (options: ModuleOptions, nuxt: Nuxt) { | |||
There was a problem hiding this comment.
Tip: You don't need types here. They are already inferred by defineNuxtModule
There was a problem hiding this comment.
Didn't know that, should we remove it then?
benjamincanac
approved these changes
Jan 14, 2022
|
Thanks a lot @pi0 🙂 |
luke-z
reviewed
Jan 15, 2022
| * @type string | ||
| * @example 'v3' | ||
| */ | ||
| version?: 'v4' | 'v4' |
There was a problem hiding this comment.
Hi @pi0
Shouldn't this be 'v4' | 'v3'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Refactor runtime types so they are bundled with
mkdist. resolves #211.Checklist: