Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hor Guide. - Updated the packages to recent versions recommended by the guide. - Updated the npm scripts accordingly. - Added a default tsconfig.json file for the playground client code. - Added a default tsconfig.json file for the playground server code. - Updated app.vue to follow linting rules. - Updated module.ts to use the import type declaration. - Added yarn run dev:prepare as a pre step to the prepack operation in the release script.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey, Thanks for this PR! I will review it and give you some hints :) And I am pretty happy that you are contributing. Keep it going! |
Baroshem
reviewed
Oct 24, 2023
package.json
Outdated
Comment on lines
2
to
3
| "name": "@idealcodeio/nuxt-medusa-test", | ||
| "version": "0.4.6", |
There was a problem hiding this comment.
issue: These changes are not needed, you can revert them :)
That's right! That was an oopsie, I forgot to change back the name when I uploaded it to the npm registry for testing. Let me do a commit to fix it. |
dimitrio-m
force-pushed
the
fix/follow-nuxt-author-guide
branch
from
d50c133 to
1fcee89
Compare
|
Sorry I made a typo on the last commit |
Baroshem
approved these changes
Oct 25, 2023
|
No worries Buddy. I am merging this PR and will release a new version soon! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version.
Types of changes
Description
Hello @Baroshem as I said in the issue #31, I had a problem that seemed related to the npm package release. I tried to execute the module locally and it worked great, but I couldn't get it to work when importing the module as an npm package. I started to investigate and noticed that the module was not following the latest Nuxt Module Author Guide, so I updated the packages, added some default configuration to TypeScript that the builder needed and finally tested the module by uploading it to an npm registry (it was my first time doing that) and it worked. I imported the test package in the project that I had the issue with in the first place, and it was a success.
Checklist:
I don't know if this changes are ok, or if we need to change another thing or do further testing (first time contributor here 😃 ). I tried executing the tests and they passed. I also tried to execute the playground example and it worked great. I also tried the package in the project that I had the problem in the first place and it worked there too.